Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/10835#discussion_r50808540
--- Diff:
core/src/test/scala/org/apache/spark/scheduler/DAGSchedulerSuite.scala ---
@@ -1606,6 +1574,25 @@ class DAGSchedulerSuite
assertDataStructuresEmpty()
}
+ test("accumulators are updated on exception failures") {
--- End diff --
Clarification question: we're not trying to change behavior for
user-defined accumulators, right? If I have a user-defined accumulator and my
task fails, then the executor itself will avoid updates to the user
accumulators by simply not sending updates for them? I guess this test is just
checking that _if_ a failed task sends accumulator updates, then those updates
are assumed to be ones that should be counted and are properly added? Might be
good to add a one-sentence comment here explaining this if you also find this
potentially confusing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
