Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/10920#discussion_r50905576
--- Diff:
common/sketch/src/main/java/org/apache/spark/util/sketch/BloomFilter.java ---
@@ -39,6 +43,28 @@
* The implementation is largely based on the {@code BloomFilter} class
from guava.
*/
public abstract class BloomFilter {
+
+ public enum Version {
+ /**
+ * {@code BloomFilter} binary format version 1 (all values written in
big-endian order):
+ * - Version number, always 1 (32 bit)
+ * - Total number of words of the underlying bit array (32 bit)
+ * - The words/longs (numWords * 64 bit)
+ * - Number of hash functions (32 bit)
--- End diff --
Nit: Scaladoc requires an extra space before `-` to form an unordered list.
I'll fix this one in #10911.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
