Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10934#discussion_r50930243
  
    --- Diff: 
streaming/src/main/scala/org/apache/spark/streaming/scheduler/JobGenerator.scala
 ---
    @@ -243,6 +243,10 @@ class JobGenerator(jobScheduler: JobScheduler) extends 
Logging {
         // Example: BlockRDDs are created in this thread, and it needs to 
access BlockManager
         // Update: This is probably redundant after threadlocal stuff in 
SparkEnv has been removed.
         SparkEnv.set(ssc.env)
    +
    +    // Enable "spark.checkpoint.recursive" to make sure that all RDDs 
marked with the checkpoint
    +    // flag are all checkpointed to avoid the stack overflow issue. See 
SPARK-6847
    +    ssc.sparkContext.setLocalProperty("spark.checkpoint.recursive", "true")
    --- End diff --
    
    `localProperties` uses `InheritableThreadLocal` so they will be inherited 
by child threads.
    
    However, looks it's better not to depend on this implicit assumption and 
just set it explicitly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to