Github user mengxr commented on a diff in the pull request: https://github.com/apache/spark/pull/10940#discussion_r51049983 --- Diff: mllib/src/main/scala/org/apache/spark/ml/classification/LogisticRegression.scala --- @@ -971,8 +971,10 @@ private class LogisticAggregator( val margin = - { var sum = 0.0 features.foreachActive { (index, value) => - if (featuresStd(index) != 0.0 && value != 0.0) { + if (featuresStd(index) != 0.0) { --- End diff -- The previous version is correct. Checking `value != 0.0` is much cheaper than computing `localCoefficientsArray(index)`.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org