Github user dbtsai commented on the pull request:
https://github.com/apache/spark/pull/10940#issuecomment-175868432
Intuitively, this makes sense to me. Since when `setFitIntercept(false)`,
those features with `std == 0` will act as the effect of intercept resulting
non-zero coefficients.
Can you add couple more tests as the following. Thanks.
First, adding two new datasets by zeroing out `binaryDataset` and making
one column as non-zero constance.
Matching the result against GLMNET like the rest of the tests when
1) setFitIntercept(false), setStandardization(false) with/without
regularization
2) setFitIntercept(false), setStandardization(true) with/without
regularization
3) setFitIntercept(true), setStandardization(false) with/without
regularization
4) setFitIntercept(true), setStandardization(true) with/without
regularization
+cc @iyounus Linear Regression may have similar issue, if you have time,
you may check it out. Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
