Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/10844#discussion_r51068499
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -88,6 +88,12 @@ case class Generate(
case class Filter(condition: Expression, child: LogicalPlan) extends
UnaryNode {
override def output: Seq[Attribute] = child.output
+
+ override def constraints: Set[Expression] = {
+ val newConstraint = splitConjunctivePredicates(condition).filter(
+ _.references.subsetOf(outputSet)).toSet
--- End diff --
style nit: we typically avoid breaking in the middle of a function call and
instead prefer to break in between calls (always pick the highest syntactic
level)
```scala
val newConstraint = splitConjunctivePredicates(condition)
.filter(_.references.subsetOf(outputSet))
.toSet
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
