Github user holdenk commented on the pull request:
https://github.com/apache/spark/pull/10962#issuecomment-176323543
Looking at params.scala shouldOwn uses a require which we should probably
stay consistent with (not saying we _shouldn't_ change it per-se just if we do
we should change both). I think throwing an exception is more reasonable for
shouldOwn since its only an internal use but hasParam is external facing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
