Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/10762#discussion_r51182690
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -171,13 +171,17 @@ case class Join(
def selfJoinResolved: Boolean =
left.outputSet.intersect(right.outputSet).isEmpty
- // Joins are only resolved if they don't introduce ambiguous expression
ids.
- override lazy val resolved: Boolean = {
+ lazy val partlyResolved: Boolean = {
childrenResolved &&
expressions.forall(_.resolved) &&
selfJoinResolved &&
condition.forall(_.dataType == BooleanType)
}
+ // Joins are only resolved if they don't introduce ambiguous expression
ids.
--- End diff --
1. add a blank line above
2. we need to explain what the different resolution modes are.
3. I don't think partlyResolved is a good name -- it doesn't really explain
anything, e.g. which part?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
