Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9940#discussion_r51232182
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/types/StructType.scala ---
    @@ -359,6 +361,18 @@ object StructType extends AbstractDataType {
       protected[sql] def fromAttributes(attributes: Seq[Attribute]): 
StructType =
         StructType(attributes.map(a => StructField(a.name, a.dataType, 
a.nullable, a.metadata)))
     
    +  def removeMetadata(key: String, dt: DataType): DataType =
    +    dt match {
    +      case StructType(fields) =>
    +        val newFields = fields.map { f =>
    +          val mb = new MetadataBuilder()
    --- End diff --
    
    This PR is mostly a workaround for a parquet-mr bug (PARQUET-389), and I'd 
assume that it will be fixed in the near future. Then we can remove this 
workaround. So it doesn't seem to be worth modifying `MetadataBuilder`, which 
is part of public API.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to