Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10630#discussion_r51233135
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -214,12 +214,22 @@ trait CheckAnalysis {
s"""Only a single table generating function is allowed in a
SELECT clause, found:
|
${exprs.map(_.prettyString).mkString(",")}""".stripMargin)
- // Special handling for cases when self-join introduce duplicate
expression ids.
- case j @ Join(left, right, _, _) if
left.outputSet.intersect(right.outputSet).nonEmpty =>
- val conflictingAttributes =
left.outputSet.intersect(right.outputSet)
+ case j: Join if !j.duplicateResolved =>
+ val conflictingAttributes =
j.left.outputSet.intersect(j.right.outputSet)
failAnalysis(
s"""
- |Failure when resolving conflicting references in Join:
--- End diff --
now we can keep this message as it only checks join :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
