Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51237016
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSourceStrategy.scala
---
@@ -251,6 +262,77 @@ private[sql] object DataSourceStrategy extends
Strategy with Logging {
}
}
+ // Get the bucket ID based on the bucketing values.
+ // Restriction: Bucket pruning works iff the bucketing column has one
and only one column.
+ private def getBucketId(bucketColumn: Attribute, numBuckets: Int, value:
Any): Int = {
+ lazy val mutableRow = new
SpecificMutableRow(Seq(bucketColumn.dataType))
--- End diff --
This won't reuse the row. Anyway it's not in critical path, we can leave it
as simple `val`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
