Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10762#discussion_r51296356
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -171,13 +171,21 @@ case class Join(
def selfJoinResolved: Boolean =
left.outputSet.intersect(right.outputSet).isEmpty
- // Joins are only resolved if they don't introduce ambiguous expression
ids.
- override lazy val resolved: Boolean = {
+ // if not a natural join, it is resolved. if it is a natural join, we
still need to
+ // eliminate natural before we mark it resolved, but the node should be
ready for
+ // resolution only if everything else is resolved here.
+ lazy val resolvedExceptNatural: Boolean = {
childrenResolved &&
expressions.forall(_.resolved) &&
selfJoinResolved &&
condition.forall(_.dataType == BooleanType)
}
+
+ // Joins are only resolved if they don't introduce ambiguous expression
ids.
--- End diff --
yup, this is the original comment for `resolved`, but now we renamed
`resolved` to `resolvedExceptNatural` right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
