Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/10942#discussion_r51342412
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/sources/BucketedReadSuite.scala ---
@@ -59,6 +61,141 @@ class BucketedReadSuite extends QueryTest with
SQLTestUtils with TestHiveSinglet
}
}
+ // To verify if pruning works, we compare the results before filtering
+ private def checkPrunedAnswers(
+ sourceDataFrame: DataFrame,
+ filterCondition: Column,
--- End diff --
instead of having these 2 parameters, how about we just ask caller to pass
in a `filteredDataFrame`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
