Github user adrian-wang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/10964#discussion_r51381272
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/SQLQuerySuite.scala 
---
    @@ -2056,4 +2056,11 @@ class SQLQuerySuite extends QueryTest with 
SharedSQLContext {
           )
         }
       }
    +
    +  test("SPARK-13056: Null in map value causes NPE") {
    +    val df = Seq(1 -> Map("abc" -> "somestring", "cba" -> 
null)).toDF("key", "value")
    +    df.registerTempTable("maptest")
    +    checkAnswer(sql("SELECT value['abc'] FROM maptest"), Row("somestring"))
    +    checkAnswer(sql("SELECT value['cba'] FROM maptest"), Row(null))
    --- End diff --
    
    @tejasapatil OK, actually I used a udf to generate the map and got your 
exception, later I changed to this following the guide from @cloud-fan but 
didn't verify it myself. I'll modify the test case here, Thanks!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to