Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/11006#discussion_r51505200
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/streaming/StreamProgress.scala
---
@@ -0,0 +1,71 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.streaming
+
+import scala.collection.mutable
+
+/**
+ * A helper class that looks like a Map[Source, Offset].
+ */
+class StreamProgress extends Serializable {
+ private val currentOffsets = new mutable.HashMap[Source, Offset]
+ with mutable.SynchronizedMap[Source, Offset]
+
+ private[streaming] def update(source: Source, newOffset: Offset): Unit =
{
+ currentOffsets.get(source).foreach(old =>
+ assert(newOffset > old, s"Stream going backwards $newOffset ->
$old"))
+ currentOffsets.put(source, newOffset)
+ }
+
+ private[streaming] def update(newOffset: (Source, Offset)): Unit =
+ update(newOffset._1, newOffset._2)
+
+ private[streaming] def apply(source: Source): Offset =
currentOffsets(source)
+ private[streaming] def get(source: Source): Option[Offset] =
currentOffsets.get(source)
+ private[streaming] def contains(source: Source): Boolean =
currentOffsets.contains(source)
+
+ private[streaming] def ++(updates: Map[Source, Offset]): StreamProgress
= {
+ val updated = new StreamProgress
+ currentOffsets.foreach(updated.update)
+ updates.foreach(updated.update)
+ updated
+ }
+
+ /**
+ * Used to create a new copy of this [[StreamProgress]]. While this
class is currently mutable,
+ * it should be copied before being passed to user code.
+ */
+ private[streaming] def copy(): StreamProgress = {
+ val copied = new StreamProgress
+ currentOffsets.foreach(copied.update)
+ copied
+ }
+
+ override def toString: String =
+ currentOffsets.map { case (k, v) => s"$k: $v"}.mkString("{", ",", "}")
+
+ override def equals(other: Any): Boolean = other match {
+ case s: StreamProgress =>
+ s.currentOffsets.keys.toSet == currentOffsets.keys.toSet &&
--- End diff --
> Both LongOffset and CompositeOffset are case classes, so I think that the
default implementation of hashCode and equals are actually okay.
Sorry, didn't notice that.
However, you can use `currentOffsets`'s `hashCode` and `equals` directly
and not need to implement it again. Right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
