Github user tedyu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11006#discussion_r51652148
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataStreamReader.scala ---
    @@ -0,0 +1,127 @@
    +/*
    +* Licensed to the Apache Software Foundation (ASF) under one or more
    +* contributor license agreements.  See the NOTICE file distributed with
    +* this work for additional information regarding copyright ownership.
    +* The ASF licenses this file to You under the Apache License, Version 2.0
    +* (the "License"); you may not use this file except in compliance with
    +* the License.  You may obtain a copy of the License at
    +*
    +*    http://www.apache.org/licenses/LICENSE-2.0
    +*
    +* Unless required by applicable law or agreed to in writing, software
    +* distributed under the License is distributed on an "AS IS" BASIS,
    +* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    +* See the License for the specific language governing permissions and
    +* limitations under the License.
    +*/
    +
    +package org.apache.spark.sql
    +
    +import scala.collection.JavaConverters._
    +
    +import org.apache.spark.Logging
    +import org.apache.spark.annotation.Experimental
    +import org.apache.spark.sql.execution.datasources.ResolvedDataSource
    +import org.apache.spark.sql.execution.streaming.StreamingRelation
    +import org.apache.spark.sql.types.StructType
    +
    +/**
    + * :: Experimental ::
    + * An interface to reading streaming data.  Use `sqlContext.streamFrom` to 
access these methods.
    + *
    + * {{{
    + *   val df = sqlContext.streamFrom
    + *    .format("...")
    + *    .open()
    + * }}}
    + */
    +@Experimental
    +class DataStreamReader private[sql](sqlContext: SQLContext) extends 
Logging {
    +
    +  /**
    +   * Specifies the input data source format.
    +   *
    +   * @since 2.0.0
    +   */
    +  def format(source: String): DataStreamReader = {
    +    this.source = source
    +    this
    +  }
    +
    +  /**
    +   * Specifies the input schema. Some data streams (e.g. JSON) can infer 
the input schema
    +   * automatically from data. By specifying the schema here, the 
underlying data stream can
    +   * skip the schema inference step, and thus speed up data reading.
    +   *
    +   * @since 2.0.0
    +   */
    +  def schema(schema: StructType): DataStreamReader = {
    +    this.userSpecifiedSchema = Option(schema)
    +    this
    +  }
    +
    +  /**
    +   * Adds an input option for the underlying data stream.
    +   *
    +   * @since 2.0.0
    +   */
    +  def option(key: String, value: String): DataStreamReader = {
    --- End diff --
    
    Should we add API which allows user to remove certain options ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to