Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11040#discussion_r51668973
  
    --- Diff: 
sql/hive-thriftserver/src/test/scala/org/apache/spark/sql/hive/thriftserver/HiveThriftServer2Suites.scala
 ---
    @@ -493,12 +493,12 @@ class HiveThriftBinaryServerSuite extends 
HiveThriftJdbcTest {
           val jarPath = "../hive/src/test/resources/TestUDTF.jar"
           val jarURL = s"file://${System.getProperty("user.dir")}/$jarPath"
     
    -      Seq(
    -        s"ADD JAR $jarURL",
    +      statement.execute(s"ADD JAR $jarURL")
    +      statement.execute(
             s"""CREATE TEMPORARY FUNCTION udtf_count2
                |AS 'org.apache.spark.sql.hive.execution.GenericUDTFCount2'
              """.stripMargin
    -      ).foreach(statement.execute)
    +      )
    --- End diff --
    
    When the original code fails, log lines only say that one of the commands 
within the `Seq` fails. I'd like to know which one fails.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to