Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11060#discussion_r51835677
--- Diff: core/src/main/scala/org/apache/spark/rdd/CoalescedRDD.scala ---
@@ -273,7 +273,8 @@ private class PartitionCoalescer(maxPartitions: Int,
prev: RDD[_], balanceSlack:
groupArr += pgroup
groupHash.getOrElseUpdate(nxt_replica, ArrayBuffer()) += pgroup
var tries = 0
- while (!addPartToPGroup(nxt_part, pgroup) && tries < targetLen) { //
ensure at least one part
+ // ensure at least one part
+ while (pgroup.arr.isEmpty && !addPartToPGroup(nxt_part, pgroup) &&
tries < targetLen) {
--- End diff --
thanks for doing this. can you explain why this is a correct fix and
doesn't change behavior, so reviewers don't need to go read and understand the
whole block?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
