Github user pwendell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1253#discussion_r15199183
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/SparkSubmitArguments.scala ---
    @@ -290,6 +291,14 @@ private[spark] class SparkSubmitArguments(args: 
Seq[String]) {
             jars = Utils.resolveURIs(value)
             parse(tail)
     
    +      case ("--conf") :: value :: tail =>
    +        val equalsIndex = value.indexOf('=')
    --- End diff --
    
    So here, it might be a bit nicer to do something like:
    
    ```
    value match {
      case k :: "=" :: v =>
        sparkProperties(k) = v
      case _ =>
        // throw exception saying there is a bad format
    }
    ```
    Would this work?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to