Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11160#discussion_r52550348
--- Diff:
launcher/src/main/java/org/apache/spark/launcher/CommandBuilderUtils.java ---
@@ -336,4 +334,18 @@ static void addPermGenSizeOpt(List<String> cmd) {
cmd.add("-XX:MaxPermSize=256m");
}
+ /**
+ * Get the major version of the java.version string supplied.
+ */
+ static int javaMajorVersion(String javaVersion) {
+ String[] version = javaVersion.split("[+.\\-]+");
--- End diff --
oh yah sorry not enough coffee for me today, I guess we need .- but not +
(although if we did use java.runtime.version we would need the +) and one of
the samples in the test "9+100" shouldn't show up in java.version but should in
java.runtime.version
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
