Github user davies commented on the pull request:
https://github.com/apache/spark/pull/11100#issuecomment-183082733
@gatorsmile Thanks for work on this.
The secret column name `GROUPING__ID` is only introduced by Hive,
unfortunately the implementation is wrong, we don't follow that(corrected it).
We can't be compatible with Hive anyway, so I'd like to not support it (it's OK
for 2.0), we can have an error message to tell user to use `grouping_id()`.
For the other bug, that could be fixed by resolve all the expressions
before GroupingSet (one line change).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
