Github user markhamstra commented on a diff in the pull request:
https://github.com/apache/spark/pull/11175#discussion_r52692010
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/TaskSetManager.scala ---
@@ -181,9 +186,7 @@ private[spark] class TaskSetManager(
private def addPendingTask(index: Int) {
// Utility method that adds `index` to a list only if it's not already
there
def addTo(list: ArrayBuffer[Int]) {
- if (!list.contains(index)) {
- list += index
- }
+ list += index
}
--- End diff --
It strikes me that `addTo` is now only making a negative contribution
toward understanding the code -- mostly because the "...if it's not already
there" comment is now wrong. I don't see why the handful of uses of `addTo`
shouldn't just be replaced with, e.g.:
```scala
pendingTasksForExecutor.getOrElseUpdate(e.executorId, new ArrayBuffer) +=
index
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
