Github user rxin commented on a diff in the pull request: https://github.com/apache/spark/pull/11171#discussion_r52714791 --- Diff: sql/hive/src/test/scala/org/apache/spark/sql/hive/SQLBuilderTest.scala --- @@ -50,10 +50,8 @@ abstract class SQLBuilderTest extends QueryTest with TestHiveSingleton { """.stripMargin) } - val actualSQL = maybeSQL.get - try { - assert(actualSQL === expectedSQL) + assert(generatedSql === expectedSQL) --- End diff -- i think both are acceptable according to java conventions. if the acronym is longer than certain characters, than the preference is to camel case.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org