Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/11148#discussion_r52728653
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/SQLBuilder.scala ---
@@ -119,6 +120,18 @@ class SQLBuilder(logicalPlan: LogicalPlan, sqlContext:
SQLContext) extends Loggi
limitSQL = limit.sql
} yield s"$childSQL LIMIT $limitSQL"
+ // TABLESAMPLE is part of tableSource clause in the parser,
+ // and thus we must handle it with subquery.
+ case Sample(lb, ub, withReplacement, _, child @ Subquery(alias,
grandChild))
--- End diff --
Agree with @rxin. Especially, I don't think `MetastoreRelation` is wrapped
by a `Subquery` in this case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
