Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11195#discussion_r52838622
--- Diff:
sql/hive/src/test/scala/org/apache/spark/sql/hive/LogicalPlanToSQLSuite.scala
---
@@ -105,6 +105,18 @@ class LogicalPlanToSQLSuite extends SQLBuilderTest
with SQLTestUtils {
checkHiveQl("SELECT id FROM t0 UNION ALL SELECT CAST(id AS INT) AS id
FROM t0")
}
+ test("union distinct") {
+ checkHiveQl("SELECT * FROM t0 UNION SELECT * FROM t0")
--- End diff --
well my worry is that if we do support that in the future, nobody will
remember coming back to this place and fix it. let's just add parentheses
around so it is robust against future changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
