Github user holdenk commented on a diff in the pull request:
https://github.com/apache/spark/pull/11203#discussion_r52852811
--- Diff: python/pyspark/ml/feature.py ---
@@ -53,6 +53,18 @@ class Binarizer(JavaTransformer, HasInputCol,
HasOutputCol):
>>> params = {binarizer.threshold: -0.5, binarizer.outputCol: "vector"}
>>> binarizer.transform(df, params).head().vector
1.0
+ >>> import tempfile
--- End diff --
So as ended up being a follow up to
https://github.com/apache/spark/pull/10999 we might want to simplify this a bit
so it is more like an example since doctests are also (ideally) readable by
users - maybe waiting for https://github.com/apache/spark/pull/11197 and then
following the pattern in that PR. cc @mengxr
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
