Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11048#discussion_r52864016
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/bucket.scala
---
@@ -35,7 +36,8 @@ import org.apache.spark.sql.types.StructType
private[sql] case class BucketSpec(
numBuckets: Int,
bucketColumnNames: Seq[String],
- sortColumnNames: Seq[String])
+ sortColumnNames: Seq[String],
--- End diff --
`BucketSpec` is used in other places. Because `sortDirections` is optional,
I don't want to change current implementation a lot.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
