Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11083#discussion_r52958542
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/WholeStageCodegen.scala
---
@@ -391,10 +394,10 @@ private[sql] case class
CollapseCodegenStages(sqlContext: SQLContext) extends Ru
var inputs = ArrayBuffer[SparkPlan]()
val combined = plan.transform {
// The build side can't be compiled together
- case b @ BroadcastHashJoin(_, _, BuildLeft, _, left, right) =>
- b.copy(left = apply(left))
- case b @ BroadcastHashJoin(_, _, BuildRight, _, left, right) =>
- b.copy(right = apply(right))
+ case b @ BroadcastHashJoin(_, _, BuildLeft, _, bc: Broadcast,
_) =>
--- End diff --
I think we don't need these anymore, since the `build` MUST be Broadcast,
which does not support codegen, will be meet the next case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
