Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/10757#issuecomment-185007809
My last concern is changing default column alias `_c0, _c1, ..` to
`Expression.sql`. Before this PR, query plans generated by SQL string will use
`_c0, _c1, ..`, query plans generated by DataFrame will use `prettyString`. Now
we always use `Expression.sql`, this is more consistent, but will break some
old code, e.g. `select _c1 from (select a + 1, b + 2 from tbl) t `, does it
worth?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
