Github user andrewor14 commented on the pull request:

    https://github.com/apache/spark/pull/10205#issuecomment-186486569
  
    @vanzin I took a pass over this and had one design question regarding 
optional configs. Otherwise the rest of the patch is pretty straightforward and 
looks reasonable. I think this is a great addition because we no longer 
duplicate the config keys and default values everywhere. (Note: I have not 
confirmed whether the semantics of each and every config are fully preserved.)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to