Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/11189#discussion_r53572447
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveMetastoreCatalog.scala ---
@@ -765,9 +771,14 @@ private[hive] case class MetastoreRelation
override protected def otherCopyArgs: Seq[AnyRef] = table :: sqlContext
:: Nil
- @transient val hiveQlTable: Table = {
+ private def toHiveColumn(c: CatalogColumn): FieldSchema = {
+ new FieldSchema(c.name, c.dataType, c.comment.orNull)
+ }
+
+ // TODO: merge this with HiveClientImpl#toHiveTable
+ @transient val hiveQlTable: HiveTable = {
// We start by constructing an API table as Hive performs several
important transformations
- // internally when converting an API table to a QL table.
+ // internally when converting an API table to a QL table.
--- End diff --
Nit: Weird spaces.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
