Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/11260#discussion_r53581595
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicOperators.scala
---
@@ -260,6 +260,20 @@ case class Join(
condition: Option[Expression])
extends BinaryNode with PredicateHelper {
+ private def isBrocastHint(plan: LogicalPlan): Boolean = {
--- End diff --
yeah, I see. But as we need to add two broadcast hint for left and right
plans. Considering Join is broadly used in many places as pattern matching
usage, I am afraid that we need to change too many places for this change.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
