Github user gatorsmile commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11298#discussion_r53585798
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
 ---
    @@ -607,14 +607,21 @@ class Analyzer(
         def apply(plan: LogicalPlan): LogicalPlan = plan resolveOperators {
           // Skip sort with aggregate. This will be handled in 
ResolveAggregateFunctions
           case sa @ Sort(_, _, child: Aggregate) => sa
    --- End diff --
    
    The above two issues have been covered in the rule 
`ResolveAggregateFunctions` when `Aggregate` is the child of `Sort`. Thus, the 
current PR keeps the existing logics without any change. 
    
    This PR is to introduce a fix for aggregate functions when there exists the 
other operators between `Aggregate` and `Sort`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to