Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/11270#discussion_r53600012
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/DataSourceDetectionSuite.scala
---
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.execution.datasources
+
+import java.io.File
+
+import org.apache.spark.SparkException
+import org.apache.spark.sql.{QueryTest, SQLConf}
+import org.apache.spark.sql.test.SharedSQLContext
+
+class DataSourceDetectionSuite extends QueryTest with SharedSQLContext {
--- End diff --
The test case I added below is the case for detection failure. Given data
is Json but it tries to read magic number since `part` files and the given
directory do not have extensions.
```scala
test("detect datasource - fail to load json without extensions") {
val data = (1 to 10).map(i => (i, i.toString))
withTempPath { file =>
val path = file.getCanonicalPath
sqlContext.createDataFrame(data).write.json(path)
val message = intercept[SparkException] {
DataSourceDetection.detect(sqlContext, path)
}.getMessage
assert(message.contains("Detected data source was"))
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
