Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11235#discussion_r53669872
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -57,6 +57,8 @@ abstract class Optimizer extends
RuleExecutor[LogicalPlan] {
ReplaceDistinctWithAggregate) ::
Batch("Aggregate", FixedPoint(100),
RemoveLiteralFromGroupExpressions) ::
+ Batch("Join", Once,
+ AddFilterOfNullForInnerJoin) ::
--- End diff --
We should make this rule idempotent instead of hacking it and making it run
only once. You are loosing the benefits of emergent optimizations with this
implementation.
I would directly construct the filter in the left/right child, but only
when its not already present in the `constraints` of the child. This is the
whole reason we added the ability to reason about what `constraints` are
already present on a subtree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
