Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/11272#discussion_r53674006
--- Diff:
network/shuffle/src/main/java/org/apache/spark/network/shuffle/protocol/BlockTransferMessage.java
---
@@ -40,7 +41,8 @@
/** Preceding every serialized message is its type, which allows us to
deserialize it. */
public static enum Type {
- OPEN_BLOCKS(0), UPLOAD_BLOCK(1), REGISTER_EXECUTOR(2),
STREAM_HANDLE(3), REGISTER_DRIVER(4);
+ OPEN_BLOCKS(0), UPLOAD_BLOCK(1), REGISTER_EXECUTOR(2),
STREAM_HANDLE(3), REGISTER_DRIVER(4),
+ HEARTBEAT(5);
--- End diff --
this is the part that's the most worrying since it doesn't core stuff. Can
you run some end-to-end tests of Spark standalone mode with external shuffle
service to ensure that everything continues to work as expected?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
