Github user nkronenfeld commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1535#discussion_r15308845
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -1269,6 +1269,19 @@ abstract class RDD[T: ClassTag](
     
       /** A description of this RDD and its recursive dependencies for 
debugging. */
       def toDebugString: String = {
    +    // Get a debug description of an rdd without its children
    +    def debugSelf (rdd: RDD[_]): Seq[String] = {
    +      import Utils.bytesToString
    +
    +      val persistence = storageLevel.description
    +      val storageInfo = rdd.context.getRDDStorageInfo.filter(_.id == 
rdd.id).map(info =>
    --- End diff --
    
    I'm not sure what you mean - do you mean "an extremely costly operation"?
    
    Assuming that to be the case, two comments::
    
     * I though about attaching flags to the function so one could specify the 
type of debug information desired; I think that makes the function too complex, 
but I'm hardly firm in that idea.
     * This whole function is specifically to help a developer with debugging.  
I don't _think_ having it be costly is all that bad.
    
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to