Github user marmbrus commented on the pull request:

    https://github.com/apache/spark/pull/993#issuecomment-49949454
  
    Okay, I think this is getting pretty close to merging in.  I've tested it 
with codegen turned on and it passes all of the tests.  I've also built it 
successfully with both maven and sbt.  I've also tried to address all of the 
previous comments.
    
    @pwendell, I'd appreciate it if you could take a quick glance at the build 
changes.  Though they ended up being pretty minimal.
    @rxin @concretevitamin @yhuai @liancheng I think you have all already 
looked at this, but if there is any other feedback please let me know.
    
    I'd like to merge this in the next day or so as it makes some pretty 
sweeping changes which might cause conflicts as we get closer to the merge 
deadline.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to