Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11389#discussion_r54293663
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
    @@ -453,6 +453,12 @@ final class DataFrameWriter private[sql](df: 
DataFrame) {
        *   format("json").save(path)
        * }}}
        *
    +   * You can set the following JSON-specific options for writing JSON 
files:
    +   * <li>`compression` or `codec` (default `null`): compression codec to 
use when saving to file.
    +   * This should be the fully qualified name of a class implementing
    +   * [[org.apache.hadoop.io.compress.CompressionCodec]] or one of the 
known case-insensitive
    --- End diff --
    
    I'd remove the mention of org.apache.hadoop.io.compress.CompressionCodec
    
    The hadoop API is so difficult to use that I don't think it deserves to be 
user-facing here.
    



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to