Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/11369#discussion_r54295354
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/mesos/MesosClusterDispatcherArguments.scala
 ---
    @@ -95,6 +100,9 @@ private[mesos] class 
MesosClusterDispatcherArguments(args: Array[String], conf:
             "  -h HOST, --host HOST    Hostname to listen on\n" +
             "  -p PORT, --port PORT    Port to listen on (default: 7077)\n" +
             "  --webui-port WEBUI_PORT WebUI Port to listen on (default: 
8081)\n" +
    +        "  --webui-url  WEBUI_URL  The WebUI URL to be set in the 
underlying\n" +
    --- End diff --
    
    There are a trillion ways to set configuration in Spark, half of them are 
deprecated, and some only work with certain entrypoint classes.
    
    Some entrypoints, like SparkSubmit, support setting arbitrary properties in 
commands w/ something like --conf.  MesosClusterDispatcher does not.  So I say 
we just rely on `--properties-file`, rather than adding a command argument just 
for this one property.  It's already arbitrary which properties are exposed as 
special command parameters, so let's not add a new one.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to