Github user sarutak commented on a diff in the pull request:
https://github.com/apache/spark/pull/11301#discussion_r54684844
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/package.scala ---
@@ -159,6 +159,19 @@ package object util {
def toCommentSafeString(str: String): String =
str.replace("*/", "\\*\\/").replace("\\u", "\\\\u")
+ /**
+ * Returns the string representation of this expression with origin that
is safe to be put in
+ * code comments of generated code.
+ */
+ def toCommentSafeString(expr: Expression): String = {
+ val str = if (expr.origin.callSite.isDefined &&
!expr.isInstanceOf[BoundReference]) {
+ expr.toString + " @ " + expr.origin.callSite.get
+ } else {
+ expr.toString
+ }
+ str.replace("*/", "\\*\\/").replace("\\u", "\\\\u")
--- End diff --
I think it's better not to overload `toCommentSafeString`. Instead of that,
how about add another method for making origin information string like
`toOriginString` to `Expression` and call the method like
`toCommentSafeString(expr.toOriginString())`?
It's just one idea.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
