Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11223#issuecomment-191669921
This needs a few things -- a rebase of course.
Next I'm concerned with dependency harmonization. For example I see
differing versions of Jackson dependencies being pulled in. I think I expect to
see both 1.x and 2.x dependencies, but not different versions of 1.x or 2.x.
Likewise with Jersey, it seems like a few 1.x dependencies are still coming in.
Figuring this out is the painful part.
We also need to update LICENSE files to reflect new dependencies.
More tests can't hurt; I don't know how to test the security aspect. Tests
do in general basically exercise the web UI already.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
