Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11406#discussion_r55103382
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -769,6 +770,27 @@ object CombineFilters extends Rule[LogicalPlan] {
}
/**
+ * Remove all the deterministic conditions in a [[Filter]] that are
contained in the Child.
+ */
+object PruneFilters extends Rule[LogicalPlan] with PredicateHelper {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case f @ Filter(fc, p: LogicalPlan) =>
+ val (prunedPredicates, remainingPredicates) =
+ splitConjunctivePredicates(fc).partition { cond =>
+ cond.deterministic && p.constraints.contains(cond)
+ }
+ if (prunedPredicates.isEmpty) {
+ f
+ } else if (remainingPredicates.isEmpty) {
+ p
+ } else {
+ val newCond =
remainingPredicates.reduceOption(And).getOrElse(Literal(true))
--- End diff --
The getOrElse is dead code given the check above.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
