Github user liancheng commented on the pull request:
https://github.com/apache/spark/pull/11538#issuecomment-192623039
This change itself LGTM. However, the current implementation of
`cleanIdentifier` doesn't handle escaped back-ticks within identifier names,
e.g. ``` `weird``name` ```. (Back-ticks within identifiers are escaped by
double-back-ticks.) But we can address this issue in another PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
