Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/11487#discussion_r55175388
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/ScalaReflectionSuite.scala
---
@@ -237,4 +241,45 @@ class ScalaReflectionSuite extends SparkFunSuite {
assert(anyTypes.forall(!_.isPrimitive))
assert(anyTypes === Seq(classOf[java.lang.Object],
classOf[java.lang.Object]))
}
+
+ private def testThreadSafetyFor(name: String)(exec: () => Any) = {
+ test(s"thread safety of ${name}") {
+ for (_ <- 0 until 100) {
--- End diff --
Yes I understand repeating it 100 times, but your idiom for iterating n
times is different on two nearby lines.
I actually meant the opposite -- remove the helper method but run `test`s
in a loop still -- but leave it.
My question was more like, does the extra locking cause trouble in 2.11? I
know you said 2.11 doesn't need this change per se.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
