Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/11235#discussion_r55247463
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -144,6 +146,56 @@ object EliminateSerialization extends
Rule[LogicalPlan] {
}
/**
+ * Add Filter to left and right of an inner Join to filter out rows with
null keys.
+ * So we may not need to check nullability of keys while joining. Besides,
by filtering
+ * out keys with null, we can also reduce data size in Join.
+ */
+object AddFilterOfNullForInnerJoin extends Rule[LogicalPlan] with
PredicateHelper {
--- End diff --
Not commenting at the name at all (haven't looked at the rest of the pr),
but AddFilterOfNullForEquiJoin can be shortened slightly to
AddNullFilterForEquiJoin
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
