Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/11509#discussion_r55254454
--- Diff:
mllib/src/test/scala/org/apache/spark/ml/source/libsvm/LibSVMRelationSuite.scala
---
@@ -88,7 +88,8 @@ class LibSVMRelationSuite extends SparkFunSuite with
MLlibTestSparkContext {
val df = sqlContext.read.format("libsvm").load(path)
val tempDir2 = Utils.createTempDir()
val writepath = tempDir2.toURI.toString
- df.write.format("libsvm").mode(SaveMode.Overwrite).save(writepath)
+ // TODO: Remove requirement to coalesce by supporting mutiple reads.
+
df.coalesce(1).write.format("libsvm").mode(SaveMode.Overwrite).save(writepath)
--- End diff --
Yeah, honestly I'm not sure where we were implicitly coalescing before, but
this is required to make the test case pass.
Before this PR the implementation had a restriction that it throws an error
if there is more than one file and I did not try and remove that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
