Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/11501#discussion_r55254711
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/CatalystQl.scala
---
@@ -661,6 +664,36 @@
https://cwiki.apache.org/confluence/display/Hive/Enhanced+Aggregation%2C+Cube%2C
val INTEGRAL = "[+-]?\\d+".r
val DECIMAL = "[+-]?((\\d+(\\.\\d*)?)|(\\.\\d+))".r
+ /**
+ * Flattens the left deep tree with the specified pattern into a list.
+ */
+ private def flattenLeftDeepTree(node: ASTNode, pattern: Regex):
Seq[ASTNode] = {
+ val collected = ArrayBuffer[ASTNode]()
+ var rest = node
+ while (rest match {
+ case Token(pattern(), l :: r :: Nil) =>
+ collected += r
+ rest = l
+ true
+ case _ => false
+ }) {}
--- End diff --
Yeah, we already do the dirty work in the condition, to avoid another
match-case in the body of while.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
