Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/11565#discussion_r55317197
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -345,8 +343,6 @@ object ColumnPruning extends Rule[LogicalPlan] {
// Prunes the unused columns from child of
Aggregate/Window/Expand/Generate
case a @ Aggregate(_, _, child) if (child.outputSet --
a.references).nonEmpty =>
a.copy(child = prunedChild(child, a.references))
- case w @ Window(_, _, _, _, child) if (child.outputSet --
w.references).nonEmpty =>
--- End diff --
I see, makes sense. But I think it's still possible to do column pruning
for window, which may require a more complex rule. We can do it in follow-ups.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
