Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/11567#issuecomment-193663305
Ah, OK I see now:
- `scalastyle` config's location was referenced incorrectly. This was a
change I should have backed out. I'm not sure why it passed the pull request
builder tests then
- I was also not sure why breaking the style rule did in fact got flagged
as if it were working: https://github.com/apache/spark/pull/11522 . I think
it's because it found the config in its default location anyway?
- `checkstyle` config was never properly updated, and this wasn't caught
since it doesn't actually run in the pull request builder (?)
This looks correct then, even given the ?s above. If it passes for several
people, great. I'll merge once these tests pass.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
